34572 - Use native context menus on Mac OS

submited by
Style Pass
2021-05-25 07:00:04

Native menus allow for a certain degree of customization by the app, via custom NSViews that are shown instead of menu items. So that means, for each horizontal row in a menu, we have the choice between two options:

For these reasons, I think we should keep using custom menus for bookmarks folders in the Bookmarks Toolbar. We may want to update their styling to be explicitly different from native menus, so that users can have the right expectations for what they can do with them. Also, for right-click context menus inside the custom bookmark folder menus, we can definitely use a native menu for the context menu. As an alternative, we could decide to drop all this extra functionality on macOS. For example, Safari doesn't let you do any of the abovementioned things in their bookmarks toolbar.

Most of our context menus only use basic menu elements and should easily work as native menus. However, we would need custom NSView implementations for the following:

Leave a Comment