inline isArray #238

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

I dig the spirit but it's copying the package verbatim 🤒 Might as well just stick with the package until you can bump and remove it. \cc @juliangruber

from my understanding the main issue is not the size but the extra downloads, we talked at the wg meeting of doing some similar things for some of our other deps like process-nextick-args and buffer-shims

The issue wasn't removing a dependency for the sake of it being another dependency. It was that the ecosystem is at a place where shims for Array.isArray are no longer necessary and that it could be dropped. That's why waiting until a major bump to drop was fine.

I don't think we're against removing it per-say just that it would be a major version bump to remove it completely and it wouldn't make sense to be one on its own, at the same time others have expressed issues with there being too many dependencies making npm installs take a lot of time and the 3 line isArray module seemed like low hanging fruit

Leave a Comment