Search code, repositories, users, issues, pull requests...
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
I've begun noticing errors deserializing the comment ID number when receiving issue webhooks. The value appears to be an int in the models but it seems GitHub has finally crossed the threshold and needs a long. The log was for a comment created webhook request.
Additionally, all the methods on IIssueCommentsClient use an int for issue number, such as Task<IReadOnlyList<IssueComment>> GetAllForIssue(string owner, string name, int number) so it seems like the int to long transition needs to be plumbed out in quite a few places. EDIT: Oops, my fault, issue number as an int is still fine, at least I don't personally know of a repo with > int.MaxValue issues/PRs. The issue at hand here is for issue ids or maybe comment ids which are not observed until you try to deserialize an API response.
why don't we change all int to long to avoid this in the future? i don't know if it is possible or if it is, then why things wasn't like this already?
