When people talk about code reviews, they focus on the reviewer. But the developer who writes the code is just as important to the review as the perso

How to Make Your Code Reviewer Fall in Love with You

submited by

Style Pass

2024-05-02 07:30:02

When people talk about code reviews, they focus on the reviewer. But the developer who writes the code is just as important to the review as the person who reads it. There’s scarcely any guidance on preparing your code for review, so authors often screw up this process out of sheer ignorance.

This article describes best practices for participating in a code review when you’re the author. In fact, by the end of this post, you’re going to be so good at sending out your code for review that your reviewer will literally fall in love with you.

They’re going to fall in love with you. Deal with it. Nobody ever complained on their deathbed that too many people fell in love with them.

Learn faster: If you prepare your changelist properly, it directs your reviewer’s attention to areas that support your growth rather than boring style violations. When you demonstrate an appreciation for constructive criticism, your reviewer provides better feedback .

Make others better: Your code review techniques set an example for your colleagues. Effective author practices rub off on your teammates, which makes your job easier when they send code to you.